Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow suggestions more often #3069
I have to say I don't get why we suppressed autosuggestions in these circumstances. It feels better to allow it, and it doesn't seem to crash or overwhelm my poor little laptop or anything.
It also suppresses after killing, which might be a little more sensible - otherwise it often suggests just what you deleted (which would be a poor man's undo).
Also I quite like that this doesn't include a single new character. All made from free-range recycled bytes.
A cursory review of the change didn't reveal any obvious bogosities. I patched it into my system and didn't observe any harmful side-effects. So I have no objection to it being merged. Nonetheless, I didn't do a deep dive into the relevant code so I would like someone else with more knowledge of this part of the fish code to give a +1 before it is merged. However, if no one raises any objections in the next six days I recommend merging it. We can always revert or amend the change if it turns out to have problems.