Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow suggestions more often #3069

wants to merge 2 commits into from


Copy link

@faho faho commented May 25, 2016

I have to say I don't get why we suppressed autosuggestions in these circumstances. It feels better to allow it, and it doesn't seem to crash or overwhelm my poor little laptop or anything.

It also suppresses after killing, which might be a little more sensible - otherwise it often suggests just what you deleted (which would be a poor man's undo).

Also I quite like that this doesn't include a single new character. All made from free-range recycled bytes.

See #3016.

faho added 2 commits May 25, 2016 21:23
It seems kinda silly to not directly do it, but it was explicitly
stopped in the code.

I'm quite good at deleting that, aren't I?

Fixes fish-shell#3016.
Copy link

A cursory review of the change didn't reveal any obvious bogosities. I patched it into my system and didn't observe any harmful side-effects. So I have no objection to it being merged. Nonetheless, I didn't do a deep dive into the relevant code so I would like someone else with more knowledge of this part of the fish code to give a +1 before it is merged. However, if no one raises any objections in the next six days I recommend merging it. We can always revert or amend the change if it turns out to have problems.

Copy link

We can try it!

Copy link


@krader1961 krader1961 closed this May 27, 2016
@zanchey zanchey added this to the next-2.x milestone May 28, 2016
@faho faho added the release notes Something that is or should be mentioned in the release notes label Aug 1, 2016
@faho faho modified the milestones: fish 2.4.0, next-2.x Sep 4, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
enhancement release notes Something that is or should be mentioned in the release notes
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants