Add completions for git blame command

[Hunsu]

I would like to know how to test it.

[faho]

Thanks for doing this!

I would like to know how to test it.

You copy the file into a directory in $fish_complete_path, e.g. ~/.config/fish/completions, and then just use it.

I'm gonna add some more comments inline.

[faho]

The "of blame output" is a bit redundant.

[faho]

For all the options that take a file, you'll want to replace the "-f" with a "-r" - they require an argument, and it can be a file - see complete --help.

These are "-S" and "--contents", for "--date" you'll probably want "-x" (no files but a required argument). Though that's another shared option (with git log again).

[Hunsu]

You copy the file into a directory in $fish_complete_path, e.g. ~/.config/fish/completions, and then just use it.

That's what I did but I got an error about string not recognized.

I'm gonna add some more comments inline.

Thanks, I will fix the issues.

[faho]

That's what I dif but I got an error about string not recognized.

You're using completions from 2.3.0 but a fish before that. The string builtin is new in 2.3.0, so you'll want to upgrade to that.

[faho]

Merged, thanks!

We probably want to add some more stuff here, but as a first pass it's not bad.

[Hunsu]

We probably want to add some more stuff here, but as a first pass it's not bad.

What more stuff do you want to add? I will look at the TODO to improve the completions for git. I read somewhere that fish shell's auto-completion uses man pages, is it true? If so why it doesn't work for git (or the other commands).

[faho]

I read somewhere that fish shell's auto-completion uses man pages, is it true?

You possibly read it on fishshell.com - it is true. We have a python script that tries to parse man pages and generate completion scripts from that. For simple stuff (commands that take files and only have long and short options that don't take arguments) it works, but for something like git man pages just aren't written in a precise enough format that it could do much. Even for simple stuff the descriptions are often "Something something something...[See the man page for details]".

So we have a lot of hand-written completions, which includes git (as you've probably seen).

What more stuff do you want to add?

Well, the arguments. From the man page, it appears git blame takes a "rev" and also files. We're not currently completing the "rev" part (which, in simplified terms, is a git-ism for those commit hashes you see all over the place).

Then we have the options that take arguments we're not completing yet, like "--encoding". We're also not yet sharing the shared options.

This is complicated stuff, and some of it might well be impossible with our current system - e.g. completing "dates", because there's an infinite number of them.