Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make kill/pkill completions more robust #3200

Closed
wants to merge 1 commit into from
Closed

make kill/pkill completions more robust #3200

wants to merge 1 commit into from

Conversation

@krader1961
Copy link
Contributor

@krader1961 krader1961 commented Jul 5, 2016

Someone running fish in an unusual locale reported that an assert() was
firing when they typed pkill c. I traced it to two bugs. First, the
__fish_make_completion_signals command was producing a weird result. Second,
the builtin complete command wasn't adequately verifying its arguments.

Fixes #3129

I've tested this on Ubuntu and OS X using the C, en_US.UTF-8, and et_EE.UTF-8 locales. On OS X I have GNU coreutils setup as my standard commands thus replacing the standard OS X kill command.

Someone running fish in an unusual locale reported that an `assert()` was
firing when they typed `pkill c`. I traced it to two bugs. First, the
__fish_make_completion_signals command was producing a weird result. Second,
the builtin `complete` command wasn't adequately verifying its arguments.

Fixes #3129
@krader1961
Copy link
Contributor Author

@krader1961 krader1961 commented Jul 5, 2016

@mikroskeem: Can you put the the __fish_make_completion_signals.fish from this PR in your ~/.config/fish/functions directory, start a fresh fish shell, and verify the problem no longer occurs?

@krader1961
Copy link
Contributor Author

@krader1961 krader1961 commented Jul 8, 2016

No feedback so I'm going to assume no one has any objections to this fix and merge it.

@zanchey
Copy link
Member

@zanchey zanchey commented Jul 8, 2016

Yes, this looks fine :-)

krader1961 added a commit that referenced this issue Jul 8, 2016
Someone running fish in an unusual locale reported that an `assert()` was
firing when they typed `pkill c`. I traced it to two bugs. First, the
__fish_make_completion_signals command was producing a weird result. Second,
the builtin `complete` command wasn't adequately verifying its arguments.

Fixes #3129
@krader1961 krader1961 closed this Jul 8, 2016
@mikroskeem
Copy link

@mikroskeem mikroskeem commented Jul 9, 2016

@krader1961 Sorry, I'm bit late to this party.

But this PR fixes my problem. I can now use my own locale freely with fish, thanks :) 👍

@krader1961 krader1961 deleted the kill-signals branch Jul 13, 2016
@faho faho added the bug label Aug 27, 2016
@faho faho added this to the next-2.x milestone Aug 27, 2016
@krader1961 krader1961 added this to the fish 2.4.0 milestone Sep 3, 2016
@krader1961 krader1961 removed this from the next-2.x milestone Sep 3, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants