make kill/pkill completions more robust #3200

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@krader1961
Member

Someone running fish in an unusual locale reported that an assert() was
firing when they typed pkill c. I traced it to two bugs. First, the
__fish_make_completion_signals command was producing a weird result. Second,
the builtin complete command wasn't adequately verifying its arguments.

Fixes #3129

I've tested this on Ubuntu and OS X using the C, en_US.UTF-8, and et_EE.UTF-8 locales. On OS X I have GNU coreutils setup as my standard commands thus replacing the standard OS X kill command.

@krader1961 krader1961 make kill/pkill completions more robust
Someone running fish in an unusual locale reported that an `assert()` was
firing when they typed `pkill c`. I traced it to two bugs. First, the
__fish_make_completion_signals command was producing a weird result. Second,
the builtin `complete` command wasn't adequately verifying its arguments.

Fixes #3129
d331e6f
@krader1961
Member

@mikroskeem: Can you put the the __fish_make_completion_signals.fish from this PR in your ~/.config/fish/functions directory, start a fresh fish shell, and verify the problem no longer occurs?

@krader1961
Member

No feedback so I'm going to assume no one has any objections to this fix and merge it.

@zanchey
Member
zanchey commented Jul 8, 2016

Yes, this looks fine :-)

@krader1961 krader1961 added a commit that referenced this pull request Jul 8, 2016
@krader1961 krader1961 make kill/pkill completions more robust (#3200)
Someone running fish in an unusual locale reported that an `assert()` was
firing when they typed `pkill c`. I traced it to two bugs. First, the
__fish_make_completion_signals command was producing a weird result. Second,
the builtin `complete` command wasn't adequately verifying its arguments.

Fixes #3129
14c7cfa
@krader1961 krader1961 closed this Jul 8, 2016
@mikroskeem

@krader1961 Sorry, I'm bit late to this party.

But this PR fixes my problem. I can now use my own locale freely with fish, thanks :) 👍

@krader1961 krader1961 deleted the krader1961:kill-signals branch Jul 13, 2016
@faho faho added the bug label Aug 27, 2016
@faho faho added this to the next-2.x milestone Aug 27, 2016
@krader1961 krader1961 modified the milestone: fish 2.4.0, next-2.x Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment