New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make kill/pkill completions more robust #3200

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@krader1961
Contributor

krader1961 commented Jul 5, 2016

Someone running fish in an unusual locale reported that an assert() was
firing when they typed pkill c. I traced it to two bugs. First, the
__fish_make_completion_signals command was producing a weird result. Second,
the builtin complete command wasn't adequately verifying its arguments.

Fixes #3129

I've tested this on Ubuntu and OS X using the C, en_US.UTF-8, and et_EE.UTF-8 locales. On OS X I have GNU coreutils setup as my standard commands thus replacing the standard OS X kill command.

make kill/pkill completions more robust
Someone running fish in an unusual locale reported that an `assert()` was
firing when they typed `pkill c`. I traced it to two bugs. First, the
__fish_make_completion_signals command was producing a weird result. Second,
the builtin `complete` command wasn't adequately verifying its arguments.

Fixes #3129
@krader1961

This comment has been minimized.

Show comment
Hide comment
@krader1961

krader1961 Jul 5, 2016

Contributor

@mikroskeem: Can you put the the __fish_make_completion_signals.fish from this PR in your ~/.config/fish/functions directory, start a fresh fish shell, and verify the problem no longer occurs?

Contributor

krader1961 commented Jul 5, 2016

@mikroskeem: Can you put the the __fish_make_completion_signals.fish from this PR in your ~/.config/fish/functions directory, start a fresh fish shell, and verify the problem no longer occurs?

@krader1961

This comment has been minimized.

Show comment
Hide comment
@krader1961

krader1961 Jul 8, 2016

Contributor

No feedback so I'm going to assume no one has any objections to this fix and merge it.

Contributor

krader1961 commented Jul 8, 2016

No feedback so I'm going to assume no one has any objections to this fix and merge it.

@zanchey

This comment has been minimized.

Show comment
Hide comment
@zanchey

zanchey Jul 8, 2016

Member

Yes, this looks fine :-)

Member

zanchey commented Jul 8, 2016

Yes, this looks fine :-)

krader1961 added a commit that referenced this pull request Jul 8, 2016

make kill/pkill completions more robust (#3200)
Someone running fish in an unusual locale reported that an `assert()` was
firing when they typed `pkill c`. I traced it to two bugs. First, the
__fish_make_completion_signals command was producing a weird result. Second,
the builtin `complete` command wasn't adequately verifying its arguments.

Fixes #3129

@krader1961 krader1961 closed this Jul 8, 2016

@mikroskeem

This comment has been minimized.

Show comment
Hide comment
@mikroskeem

mikroskeem Jul 9, 2016

@krader1961 Sorry, I'm bit late to this party.

But this PR fixes my problem. I can now use my own locale freely with fish, thanks :) 👍

mikroskeem commented Jul 9, 2016

@krader1961 Sorry, I'm bit late to this party.

But this PR fixes my problem. I can now use my own locale freely with fish, thanks :) 👍

@krader1961 krader1961 deleted the krader1961:kill-signals branch Jul 13, 2016

@faho faho added the bug label Aug 27, 2016

@faho faho added this to the next-2.x milestone Aug 27, 2016

@krader1961 krader1961 modified the milestones: fish 2.4.0, next-2.x Sep 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment