Fix brew completion for brew install

[tjjh89017]

Description

Since brew mirgate Formula into Taps diectory
Change the way to find out all Homebrew-Core Formula
Compatible with old version Homebrew

[floam]

Let's try to use the string builtin here instead of sed

[floam]

Might it assume less and be more future-proof (and able to generalize to other Taps) if you get the Formula directory via: brew --repository homebrew/homebrew-core?

[floam]

This is pretty broken in master right now, I'm merging the fix.

[floam]

Wait, this is wrong:

set -l formuladir (brew --repository)/Library/Formula/ (brew --repository homebrew/core)

[tjjh89017]

brew --repository homebrew/core is working fine.
But now I just use brew search to list all local formula, however it has some problem when tap-pin is used.

[floam]

Something like this will get a working path for the main keg.

> echo (brew --repository homebrew/homebrew-core)/Formula
/usr/local/Library/Taps/homebrew/homebrew-core/Formula

[floam]

Compared to what I was getting from the PR update:

> echo (brew --repository)/Library/Formula/ (brew --repository homebrew/core)
/usr/local/Library/Formula/ /usr/local/Library/Taps/homebrew/homebrew-core

> ls /usr/local/Library/Formula/
ls: /usr/local/Library/Formula/: No such file or directory

[floam]

Oh, I see, probably that's fine and for compatibility with other installs, not necessarily a problem.

[tjjh89017]

/usr/local/Library/Formula/ for compatible
find will search recursively because some custom tap won't have Formula directory.
Dont specify Formula for try to modify easily to search all formula from Taps.
But it seems useless, while using brew search instead

[floam]

I will try this soon. How is the speed of brew search?

[tjjh89017]

brew search seem a little slower than find & string replace using Macbook Air 2014.
But I think brew search will be the better choice for this purpose because it's portable.

[floam]

That's much better than I'm getting. Maybe something is wrong with my install.

floam@MacBook-Pro ~> brew search x > /dev/null
floam@MacBook-Pro ~> echo $CMD_DURATION 
14438

edit: it's because I had a query. Seems fine to me.

[floam]

I like it, and you can just use brew search directly now instead of wrapping it in that function.

[tjjh89017]

With fresh install Hackintosh (Yosemite) last week.

$ find . -name "*.rb" -type f 2> /dev/null | string replace -r '^/(?:[^/]*/)*([^/]*)\.rb' '$1' 1> /dev/null
$ echo $CMD_DURATION
233
$ brew search 1> /dev/null
$ echo $CMD_DURATION
333

[floam]

Let me know when you're done and happy and I'll merge this to master.

Thanks!

[tjjh89017]

For brew install I think it is done.
You could merge it when anytime you want.
I will work on for other issues (e.g. tap-pin) and create another PR for fix
Thanks a lot. :)