New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use PATH to find getent in __fish_complete_groups #3383

Merged
merged 1 commit into from Sep 16, 2016

Conversation

Projects
None yet
3 participants
@andrew-schulman
Contributor

andrew-schulman commented Sep 16, 2016

Description

Use command -s getent instead of test -x /usr/bin/getent to find getent, per discussion in #3380.

TODOs:

  • Changes to fish usage are reflected in user documenation/manpages.
  • Tests have been added for regressions fixed

@faho faho merged commit 0a6dc2a into fish-shell:master Sep 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@faho

This comment has been minimized.

Show comment
Hide comment
@faho

faho Sep 16, 2016

Member

Thanks!

Member

faho commented Sep 16, 2016

Thanks!

@faho faho added the enhancement label Sep 16, 2016

@faho faho added this to the fish 2.4.0 milestone Sep 16, 2016

@zanchey

This comment has been minimized.

Show comment
Hide comment
@zanchey

zanchey Oct 2, 2016

Member

😰

Member

zanchey commented Oct 2, 2016

😰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment