New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for struct stat.st_ctime_nsec before using #3442

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@fornwall
Contributor

fornwall commented Oct 10, 2016

Using a configure check for stat.st_ctime_nsec fixes building on Android which has that field but does not define STAT_HAVE_NSEC.

Before this change the Android build failed on the st_ctim.tv_nsec fallback #else clause.

This patch is part of an effort to upstream patches used by the fish package in Termux.

Check for struct stat.st_ctime_nsec before using
Using a configure check for stat.st_ctime_nsec fixes building on
Android which has that field but does not define STAT_HAVE_NSEC.

Before this change the Android build failed on the st_ctim.tv_nsec
fallback #else clause.
@floam

This comment has been minimized.

Show comment
Hide comment
@floam

floam Oct 11, 2016

Member

LGTM

Member

floam commented Oct 11, 2016

LGTM

@krader1961

This comment has been minimized.

Show comment
Hide comment
@krader1961

krader1961 Oct 11, 2016

Contributor

Merged as commit 36f3205.

Contributor

krader1961 commented Oct 11, 2016

Merged as commit 36f3205.

@krader1961 krader1961 closed this Oct 11, 2016

@zanchey zanchey added this to the fish 2.4.0 milestone Oct 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment