New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bzr completion. Closes #3661 #3769

Merged
merged 6 commits into from Jan 25, 2017

Conversation

Projects
None yet
2 participants
@cprieto
Contributor

cprieto commented Jan 24, 2017

Description

  • Add basic completion for bzr commands
  • Include short and log options for common commands
  • Removed not so common commands

Fixes issue #3661

TODOs:

  • Changes to fish usage are reflected in user documenation/manpages.
  • Tests have been added for regressions fixed
Improve bzr completion. Closes #3661
 * Add basic completion for bzr commands
 * Include short and log options for common commands
 * Removed not so common commands
Show outdated Hide outdated share/completions/bzr.fish
Show outdated Hide outdated share/completions/bzr.fish
Show outdated Hide outdated share/completions/bzr.fish
Show outdated Hide outdated share/completions/bzr.fish
Show outdated Hide outdated share/completions/bzr.fish
@faho

This comment has been minimized.

Show comment
Hide comment
@faho

faho Jan 24, 2017

Member

Thanks for this!

Of course, this being a vcs (and those being really fricking complicated), there's about 50 million more things we could add, but this is a worthwhile first pass.

The failing tests are because of a failing master you've based this on, nothing to worry about.

Also, I'd appreciate any changes as additional commits - some people prefer force-pushing, but I like seeing what changed between versions while reviewing. I'll then squash or otherwise massage it when merging.

Member

faho commented Jan 24, 2017

Thanks for this!

Of course, this being a vcs (and those being really fricking complicated), there's about 50 million more things we could add, but this is a worthwhile first pass.

The failing tests are because of a failing master you've based this on, nothing to worry about.

Also, I'd appreciate any changes as additional commits - some people prefer force-pushing, but I like seeing what changed between versions while reviewing. I'll then squash or otherwise massage it when merging.

cprieto added some commits Jan 25, 2017

Remove '=' as suggested by #3769
 * We don't need '=' in long options
Use fish helper functions for autocomplete
To avoid issues pointed out in #3769 helper functions included in fish
are used (__fish_use_subcommand and __fish_seen_subcommand).

@faho faho added this to the next-minor milestone Jan 25, 2017

@faho faho merged commit b7d60dc into fish-shell:master Jan 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@faho

This comment has been minimized.

Show comment
Hide comment
@faho

faho Jan 25, 2017

Member

Nice work, thanks!

Member

faho commented Jan 25, 2017

Nice work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment