New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completions for minikube #3778

Merged
merged 5 commits into from Feb 2, 2017

Conversation

Projects
None yet
2 participants
@terlar
Contributor

terlar commented Jan 25, 2017

This adds basic completions for minikube, the subcommands and their options.

Add completions for minikube
This adds basic completions for minikube, the subcommands and their options.
@faho
  • Use "-a" more
  • Merge "-s" and "-l" invocations
  • Shorten/Tighten up some descriptions (brevity is important here since it allows more options on screen)
Show outdated Hide outdated share/completions/minikube.fish
@@ -0,0 +1,79 @@
function __minikube_no_command

This comment has been minimized.

@faho

faho Jan 25, 2017

Member

Please add a comment saying what this is, with a link.

@faho

faho Jan 25, 2017

Member

Please add a comment saying what this is, with a link.

Show outdated Hide outdated share/completions/minikube.fish
Show outdated Hide outdated share/completions/minikube.fish
Show outdated Hide outdated share/completions/minikube.fish
Show outdated Hide outdated share/completions/minikube.fish
Show outdated Hide outdated share/completions/minikube.fish
Show outdated Hide outdated share/completions/minikube.fish
Show outdated Hide outdated share/completions/minikube.fish
Show outdated Hide outdated share/completions/minikube.fish

@faho faho added this to the next-minor milestone Jan 25, 2017

@terlar

This comment has been minimized.

Show comment
Hide comment
@terlar

terlar Jan 26, 2017

Contributor

Thank you for all the great feedback, I will try to address all your comments and get back to you.

Contributor

terlar commented Jan 26, 2017

Thank you for all the great feedback, I will try to address all your comments and get back to you.

Improve minikube completions
- Use more consistent and shorter descriptions.
- Fix subcommand options
- Add more semantic completions
@terlar

This comment has been minimized.

Show comment
Hide comment
@terlar

terlar Jan 30, 2017

Contributor

I have totally reworked the completions based on your comments and going through the documentation and updated them, I think this should be much better.

Contributor

terlar commented Jan 30, 2017

I have totally reworked the completions based on your comments and going through the documentation and updated them, I think this should be much better.

terlar added some commits Feb 2, 2017

@faho faho merged commit bf84879 into fish-shell:master Feb 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@faho

This comment has been minimized.

Show comment
Hide comment
@faho

faho Feb 2, 2017

Member

Merged, thanks!

Member

faho commented Feb 2, 2017

Merged, thanks!

terlar added a commit to terlar/dotfiles that referenced this pull request Feb 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment