Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hg completions] remove a grep and use hg's native query syntax #3975

Merged
merged 1 commit into from Apr 21, 2017

Conversation

@alex
Copy link
Contributor

@alex alex commented Apr 21, 2017

Description

Small simplification of the hg completions code, likely a teeny tiny performance win from not spawning two processes.

This has the side benefit of working around a wild bug with readline+fish that I've reported to the upstream readline developers. (The result of that bug is that the hg processes are constantly being leaked as bg jobs in the shell, which is how I came to notice this in the first place)

This has the side benefit of working around a wild bug with readline+fish that I've reported to the upstream readline developers. (The result of that bug is that the hg processes are constantly being leaked as `bg` jobs in the shell, which is how I came to notice this in the first place)
@faho
Copy link
Member

@faho faho commented Apr 21, 2017

This has the side benefit of working around a wild bug with readline+fish that I've reported to the upstream readline developers.

What's using readline here? Fish used to, but it now has its own implementation.

The result of that bug is that the hg processes are constantly being leaked as bg jobs in the shell, which is how I came to notice this in the first place

That's most likely a result of #3952 - it seems hg is attempting to read the terminal, and fish sets up the process groups wrong.

Anyway, the patch is good and goes in.

@faho faho merged commit f30c50c into fish-shell:master Apr 21, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@faho faho added this to the 2.6.0 milestone Apr 21, 2017
@alex alex deleted the alex:patch-1 branch Apr 21, 2017
@alex
Copy link
Contributor Author

@alex alex commented Apr 21, 2017

The readline comes from hg (python). Thanks for the quick merge!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.