New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gsettings completions #4001

Merged
merged 1 commit into from May 8, 2017

Conversation

Projects
None yet
3 participants
@sbstnk
Contributor

sbstnk commented May 1, 2017

Description

This adds completions for the 'gsettings' utility shipped with glib. The suggestions for schemas/keys follow the custom schemas directory specified using --schemadir. This is useful for configuring gnome-shell extensions that ship their own schemas and done in a similar way as in the bash completions.

@sbstnk

This comment has been minimized.

Show comment
Hide comment
@sbstnk

sbstnk May 1, 2017

Contributor

I've updated everything according to the comments and also fixed another issue I noticed. The 'echo' was not enough to expand '~' if it was used in the '--schemadir' option, I needed to add an 'eval' as well.

Contributor

sbstnk commented May 1, 2017

I've updated everything according to the comments and also fixed another issue I noticed. The 'echo' was not enough to expand '~' if it was used in the '--schemadir' option, I needed to add an 'eval' as well.

Show outdated Hide outdated share/completions/gsettings.fish
Show outdated Hide outdated share/completions/gsettings.fish
Show outdated Hide outdated share/completions/gsettings.fish
@sbstnk

This comment has been minimized.

Show comment
Hide comment
@sbstnk

sbstnk May 7, 2017

Contributor

I've changed everything to use 'string' now instead of loops+echo. I've also noticed that the single quotes are required in the case of complex settings (e.g. org.gnome.settings-daemon.plugins.xsettings overrides), so I'm not removing them anymore in the enum or * case. The boolean case on the other hand does not work when using single quotes, so I did not add them there. And finally I've removed the path expansion code and added a TODO comment about supporting this properly.

Contributor

sbstnk commented May 7, 2017

I've changed everything to use 'string' now instead of loops+echo. I've also noticed that the single quotes are required in the case of complex settings (e.g. org.gnome.settings-daemon.plugins.xsettings overrides), so I'm not removing them anymore in the enum or * case. The boolean case on the other hand does not work when using single quotes, so I did not add them there. And finally I've removed the path expansion code and added a TODO comment about supporting this properly.

@faho faho merged commit 6620b9e into fish-shell:master May 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@faho faho added this to the 2.6.0 milestone May 8, 2017

@faho

This comment has been minimized.

Show comment
Hide comment
@faho

faho May 8, 2017

Member

Merged, thanks!

Member

faho commented May 8, 2017

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment