Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make npm run-script completion faster with jq #4241

Merged
merged 3 commits into from Jul 26, 2017

Commits on Jul 25, 2017

  1. Make npm run-script completion faster with jq

    When jq is available, it's actually faster to invoke jq and parse the `package.json`
    invoking the `npm` command.
    
    Also, prior to this commit, both `__fish_complete_npm` and `__fish_npm_run` were being run
    whenever completions for `npm run` subcommand was being used, which was actually making
    repetitive work (invoking npm command twice). This pull request is supposed to make completion
    without `jq` faster as well
    thalesmello committed Jul 25, 2017
    Copy the full SHA
    d85ae36 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2017

  1. Refactor npm.fish for code reutilization

    Created function to handle both cases of npm run completion parse, with or without `jq` completion.
    thalesmello committed Jul 26, 2017
    Copy the full SHA
    f37edfc View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    dcc8cb4 View commit details
    Browse the repository at this point in the history