Add completion for packages in update subcommand #4295
Conversation
This patch adds completion for the update subcommand, that is, when the user types in `composer update <tab>`. The code depends on python for the json parsing. I'm not sure if this is appropriate or if there is a fish-native way to parse json data.
share/completions/composer.fish
Outdated
| function __fish_composer_packages | ||
| echo " | ||
| import json | ||
| json_data = open('composer.json') |
There was a problem hiding this comment.
Is it safe to assume composer.json is in the CWD?
Using python for this is fine since fish has no ability to handle JSON (this might change in the 3.x releases planned for next year).
There was a problem hiding this comment.
The composer command only works when you are in the directory with composer.json. So nobody would usually start it from anywhere else most likely. But if they did the code above would probably fail.
I will add some error handling.
There was a problem hiding this comment.
@Fuco1, Ping? Just wondering if you're going to make this fail gracefully if the composer.json file isn't in the CWD. I don't think we want to merge this if it doesn't fail gracefully. Note that you don't have to modify the python code. You can simply predicate running the python code on whether the file exists using fish script. That is modify function __fish_composer_packages to do something like test -f composer.json; or return before running the python code. What we don't want are python exceptions being shown to the user.
There was a problem hiding this comment.
@krader1961 I totally forgot about this
|
Well, so I've also added some missing commands and more suggestions for some other commands too. Maybe I should rename the pull request? We can also split it into more PRs if you want. |
|
Squash merged as commit 3fe561b. Thx. |
|
Awesome, thanks! :) Sorry for the delay. |
Description
This patch adds completion for the update subcommand, that is, when the user types in
composer update <tab>.The code depends on python for the json parsing. I'm not sure if this is appropriate or if there is a fish-native way to parse json data.
TODOs: