New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion for packages in update subcommand #4295

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Fuco1
Contributor

Fuco1 commented Aug 8, 2017

Description

This patch adds completion for the update subcommand, that is, when the user types in composer update <tab>.

The code depends on python for the json parsing. I'm not sure if this is appropriate or if there is a fish-native way to parse json data.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md
Add completion for packages in update subcommand
This patch adds completion for the update subcommand, that is, when the user types in `composer update <tab>`.

The code depends on python for the json parsing.  I'm not sure if this is appropriate or if there is a fish-native way to parse json data.
@Fuco1

This comment has been minimized.

Show comment
Hide comment
@Fuco1

Fuco1 Aug 17, 2017

Contributor

Well, so I've also added some missing commands and more suggestions for some other commands too. Maybe I should rename the pull request? We can also split it into more PRs if you want.

Contributor

Fuco1 commented Aug 17, 2017

Well, so I've also added some missing commands and more suggestions for some other commands too. Maybe I should rename the pull request? We can also split it into more PRs if you want.

@krader1961

This comment has been minimized.

Show comment
Hide comment
@krader1961

krader1961 Aug 17, 2017

Contributor

Squash merged as commit 3fe561b. Thx.

Contributor

krader1961 commented Aug 17, 2017

Squash merged as commit 3fe561b. Thx.

@krader1961 krader1961 closed this Aug 17, 2017

@krader1961 krader1961 added this to the fish 2.7.0 milestone Aug 17, 2017

@Fuco1

This comment has been minimized.

Show comment
Hide comment
@Fuco1

Fuco1 Aug 18, 2017

Contributor

Awesome, thanks! :) Sorry for the delay.

Contributor

Fuco1 commented Aug 18, 2017

Awesome, thanks! :) Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment