New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repo completion for zypper #4325

Merged
merged 4 commits into from Sep 6, 2017

Conversation

Projects
None yet
4 participants
@Sam0523
Contributor

Sam0523 commented Aug 13, 2017

No description provided.

@@ -1,7 +1,8 @@
# completion for zypper
set -g __fish_zypper_all_commands shell sh repos lr addrepo ar removerepo rr renamerepo nr modifyrepo mr refresh ref clean services ls addservice as modifyservice ms removeservice rs refresh-services refs install in remove rm verify ve source-install si install-new-recommends inr update up list-updates lu patch list-patches lp dist-upgrade dup patch-check pchk search se info if patch-info pattern-info product-info patches pch packages pa patterns pt products pd what-provides wp addlock al removelock rl locks ll cleanlocks cl versioncmp vcmp targetos tos licenses source-download
set -g __fish_zypper_all_commands shell sh repos lr addrepo ar removerepo rr renamerepo nr modifyrepo mr refresh ref clean cc services ls addservice as modifyservice ms removeservice rs refresh-services refs install in remove rm verify ve source-install si install-new-recommends inr update up list-updates lu patch list-patches lp dist-upgrade dup patch-check pchk search se info if patch-info pattern-info product-info patches pch packages pa patterns pt products pd what-provides wp addlock al removelock rl locks ll cleanlocks cl versioncmp vcmp targetos tos licenses source-download

This comment has been minimized.

@krader1961

krader1961 Aug 13, 2017

Contributor

FYI, It is better to append new values to lists of this nature. If for no other reason than to make figuring out what changed easier.

@krader1961

krader1961 Aug 13, 2017

Contributor

FYI, It is better to append new values to lists of this nature. If for no other reason than to make figuring out what changed easier.

This comment has been minimized.

@krader1961

krader1961 Aug 13, 2017

Contributor

Ah! I see why you did it this way. It mimics the other commands which pair the short and long subcommands. Ignore my previous comment.

@krader1961

krader1961 Aug 13, 2017

Contributor

Ah! I see why you did it this way. It mimics the other commands which pair the short and long subcommands. Ignore my previous comment.

This comment has been minimized.

@Sam0523

Sam0523 Aug 13, 2017

Contributor

Exactly.

@Sam0523

Sam0523 Aug 13, 2017

Contributor

Exactly.

@faho
  • Move function into the completion script

  • Ideally port to string.

Show outdated Hide outdated share/functions/__fish_print_zypp_repos.fish Outdated
@Sam0523

This comment has been minimized.

Show comment
Hide comment
@Sam0523

Sam0523 Aug 15, 2017

Contributor

@faho Changes done. Please review.

Contributor

Sam0523 commented Aug 15, 2017

@faho Changes done. Please review.

@faho faho added this to the fish-3.0 milestone Sep 6, 2017

@faho

faho approved these changes Sep 6, 2017

@faho faho merged commit 81becc5 into fish-shell:master Sep 6, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@faho

This comment has been minimized.

Show comment
Hide comment
@faho

faho Sep 6, 2017

Member

Merged, thanks, and sorry for the delay!

Member

faho commented Sep 6, 2017

Merged, thanks, and sorry for the delay!

zanchey added a commit that referenced this pull request Sep 6, 2017

Add repo completion for zypper (#4325)
* Add repo completion for zypper

* Replace sed with string in __fish_print_zypp_repos

* Move function into completion script

* Update zypper completion

add subcommand packages to __fish_zypper_repo_commands

(cherry picked from commit 81becc5)

@zanchey zanchey modified the milestones: fish 2.7.0, fish-3.0 Sep 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment