Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
This will respect the directory
This also makes sure __fish_print_xdg_applications_directories only prints directories that exist. Relevant specs: https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html https://specifications.freedesktop.org/desktop-entry-spec/latest/ape.html
I adjusted my changes according to the remarks.
I also checked the XDG spec and updated the code to actually comply with it.
Relevant parts of the XDG desktop entry specification:
And two other questions:
Those are language translation files (known as "localization" and "L10N" files). In general you don't have to worry about those unless you happen to read/write one of the languages and want to help keep the translations in sync with the english messages.
You can but as a general rule you don't need to. Whomever merges your PR (me in this case) will take care of it if that's the appropriate thing to do.