Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --force-with-lease completion for git push #4368

merged 1 commit into from Aug 31, 2017


Copy link

@benjmin-r benjmin-r commented Aug 30, 2017


Besides the well known --force switch to git push there's the very useful --force-with-lease which prevents accidently overwriting refs that others have pushed to a branch since one last pulled.

With this PR I want to add completions for this switch.

As this is my first ever PR to the fish code base and I'm a fish user for less than a week, I very likely missed something. Plus it's hard for me to verify the correctness of the change besides changing that file locally, as I haven't set up the project for development (which also would kind of seem overkill for such a minor change).

In any case I'm happy to do additional changes to this PR, though I'm unsure about how relevant the template TODO items below are for such a change, especially when looking at comparable PRs (such as #4367)


  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in
@ridiculousfish ridiculousfish merged commit 72244de into fish-shell:master Aug 31, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Copy link

@ridiculousfish ridiculousfish commented Aug 31, 2017


zanchey added a commit that referenced this pull request Sep 1, 2017
(cherry picked from commit 72244de)
@zanchey zanchey added this to the fish 2.7.0 milestone Sep 2, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.