New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --force-with-lease completion for git push #4368

Merged
merged 1 commit into from Aug 31, 2017

Conversation

Projects
None yet
3 participants
@benjmin-r
Contributor

benjmin-r commented Aug 30, 2017

Description

Besides the well known --force switch to git push there's the very useful --force-with-lease which prevents accidently overwriting refs that others have pushed to a branch since one last pulled.

With this PR I want to add completions for this switch.

As this is my first ever PR to the fish code base and I'm a fish user for less than a week, I very likely missed something. Plus it's hard for me to verify the correctness of the change besides changing that file locally, as I haven't set up the project for development (which also would kind of seem overkill for such a minor change).

In any case I'm happy to do additional changes to this PR, though I'm unsure about how relevant the template TODO items below are for such a change, especially when looking at comparable PRs (such as #4367)

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md

@ridiculousfish ridiculousfish merged commit 72244de into fish-shell:master Aug 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Aug 31, 2017

Member

Thanks!!

Member

ridiculousfish commented Aug 31, 2017

Thanks!!

zanchey added a commit that referenced this pull request Sep 1, 2017

@zanchey zanchey added this to the fish 2.7.0 milestone Sep 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment