Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print --help to stdout like other builtins #5495

Merged
merged 1 commit into from Jan 9, 2019
Merged

print --help to stdout like other builtins #5495

merged 1 commit into from Jan 9, 2019

Conversation

McKayJT
Copy link
Contributor

@McKayJT McKayJT commented Jan 8, 2019

Description

Other builtins print --help to stdout so string should as well.

Found when string -h | less -R unexpectedly returned a pager with nothing in it.

floam
floam approved these changes Jan 9, 2019
View reviewed changes
Copy link
Member

@floam floam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@floam floam merged commit a6fa237 into fish-shell:master Jan 9, 2019
@floam
Copy link
Member

floam commented Jan 10, 2019

Thanks @McKayJT!

@zanchey zanchey added this to the fish 3.1.0 milestone Jan 10, 2019
@zanchey zanchey added the bug Something that's not working as intended label Jan 10, 2019
@floam floam modified the milestones: fish 3.1.0, fish 3.0.1 Jan 23, 2019
floam pushed a commit that referenced this pull request Jan 23, 2019
@McKayJT
print --help to stdout like other builtins (#5495)
e462c6f
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@floam floam floam approved these changes

Assignees
No one assigned
Labels
bug Something that's not working as intended
Projects
None yet
Milestone
fish 3.0.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@McKayJT @floam @zanchey