Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print --help to stdout like other builtins #5495

Merged
merged 1 commit into from Jan 9, 2019

Conversation

Projects
None yet
3 participants
@McKayJT
Copy link
Contributor

McKayJT commented Jan 8, 2019

Description

Other builtins print --help to stdout so string should as well.

Found when string -h | less -R unexpectedly returned a pager with nothing in it.

@floam

floam approved these changes Jan 9, 2019

Copy link
Member

floam left a comment

Looks good to me.

@floam floam merged commit a6fa237 into fish-shell:master Jan 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@floam

This comment has been minimized.

Copy link
Member

floam commented Jan 10, 2019

Thanks @McKayJT!

@zanchey zanchey added this to the fish 3.1.0 milestone Jan 10, 2019

@zanchey zanchey added the bug label Jan 10, 2019

@floam floam modified the milestones: fish 3.1.0, fish 3.0.1 Jan 23, 2019

floam added a commit that referenced this pull request Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.