Add completions for Mariner #5718
Conversation
share/completions/mariner.fish
Outdated
|
|
||
| # Global options | ||
| complete -f -n "__fish_use_subcommand $subcommands" -c mariner -l 'version' --description "Show program's version number and exit" | ||
| complete -f -n "__fish_use_subcommand $subcommands" -c mariner -s 'v' -l 'verbose' --description "Increase verbosity of output. Can be repeated." |
There was a problem hiding this comment.
Not all arguments need to be quoted. And while you shouldn't always check if something has to be quoted or not, if it's one simple word it shouldn't be - -s v -l verbose is nicer to look at, and saves 4 characters which makes the line a bit shorter.
Also the description should not end in a period (space is at a premium for descriptions because every character less makes it more likely that you can fit more columns).
There was a problem hiding this comment.
I have a habit to quote all strings, so syntax checker picks them up :]. I've removed them sin the following commit.
Good observation on the periods! I should remove them from Mariner itself as well.
share/completions/mariner.fish
Outdated
| set -l subcommands complete config details download help magnet open search | ||
|
|
||
| # Subcommands | ||
| complete -f -n "__fish_use_subcommand $subcommands" -c mariner -a 'complete' --description "Print bash completion command (cliff)" |
There was a problem hiding this comment.
It's just a comment that comes from the underlying CLI framework. I've removed it.
|
Merged, thanks! |
Description
Add completions for Mariner.
Fixes issue #
TODOs: