Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functions/help: Try harder to find a browser on WSL #5759

merged 2 commits into from Mar 27, 2019


Copy link

@faho faho commented Mar 22, 2019

We now try cmd.exe via $PATH and via a common location, wsl-open, and
an open command.

Fixes #5756.

[ci skip]


  • [N/A] Changes to fish usage are reflected in user documentation/manpages.
  • [N/A] Tests have been added for regressions fixed
  • User-visible changes noted in

Also, there's an open question: Should we do this in help, or should we augment open instead?

Some systems like Debian have "open" as a symlink to "openvt" (for... historical

See fish-shell#5756.

[ci skip]
We now try cmd.exe via $PATH and via a common location, wsl-open, and
an open command.

Fixes fish-shell#5756.

[ci skip]
@faho faho merged commit 2a51e42 into fish-shell:master Mar 27, 2019
@faho faho mentioned this pull request Mar 27, 2019
@faho faho deleted the help-wsl branch April 1, 2019 14:07
@faho faho modified the milestones: fish 3.1.0, fish 3.0.3 Apr 6, 2019
@zanchey zanchey modified the milestones: fish 3.0.3, fish 3.1.0 Aug 14, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

help command makes assumptions about PATH in WSL environment
2 participants