New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add completions for GnuPG 2.x #6062
Closed
LawAbidingCactus
wants to merge
5
commits into
fish-shell:master
from
LawAbidingCactus:gpg2-completions
Closed
Add completions for GnuPG 2.x #6062
LawAbidingCactus
wants to merge
5
commits into
fish-shell:master
from
LawAbidingCactus:gpg2-completions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that would be great |
zanchey
reviewed
Sep 2, 2019
3 tasks
zanchey
reviewed
Sep 3, 2019
zanchey
reviewed
Sep 3, 2019
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Fish's current completions for GnuPG are written for 1.x. They incompletely cover GPG 2.x and include options or subcommands that were removed in the second version. The exact differences between the two tools, with respect to their CLIs, can be viewed with the following set of commands:
With recent versions of both tools, this generates the following list of version-specific commands.
This set of completions is mostly copied from fish's existing completions for GPG. It removes GPG 1.x-specific completions and adds GPG 2.x-specific completions.
The following was discussed briefly in #2401, but remained unresolved. On many systems,
gpg
is symlinked togpg2
-- when this is the case, it would be more appropriate to use these completions than fish's current ones (withgpg2
in the completion script replaced withgpg
).gpg.fish
could test for the GPG version and activate version-specific completions depending on the result. Something like the following:This would be fairly trivial for me to do if you guys are okay with it.
TODOs: