New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple hack to emulate bash/zsh's HISTCONTROL=ignorespace #615

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@kvs
Contributor

kvs commented Mar 9, 2013

A leading space on a command will skip saving in history.

I thought about making this configurable, or adding an option
to the history builtin, but it all just seemed too complex for
such a simple thing.

An alternative would've been a built-in command like 'nohist'
or somesuch, but that also seemed excessive.

kvs added some commits Mar 9, 2013

Simple hack to emulate bash/zsh's HISTCONTROL.
A leading space on a command will skip saving in history.

I thought about making this configurable, or adding an option
to the `history` builtin, but it all just seemed too complex for
such a simple thing.
@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Mar 10, 2013

Member

Merged here:

To git@github.com:fish-shell/fish-shell.git
1afdbb8..4cce303 master -> master

I took the documentation commit (thanks for remembering to do that) but 09e5ebe had a few issues:

  • should use .at(0) instead of c_str()[0]
  • should compare against a wchar_t: L' '

So I implemented those. Thanks!

Member

ridiculousfish commented Mar 10, 2013

Merged here:

To git@github.com:fish-shell/fish-shell.git
1afdbb8..4cce303 master -> master

I took the documentation commit (thanks for remembering to do that) but 09e5ebe had a few issues:

  • should use .at(0) instead of c_str()[0]
  • should compare against a wchar_t: L' '

So I implemented those. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment