Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iw completions #6232

Closed
wants to merge 6 commits into from
Closed

Conversation

rianadon
Copy link
Contributor

Description

This is my current initial stab at completions for the iw command. This is my first time writing fish completions so feedback would be appreciated!

This is currently a WIP as there are a few commands I still need to add to the completions.

Fixes issue #5977.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md

share/completions/iw.fish Show resolved Hide resolved
share/completions/iw.fish Show resolved Hide resolved
share/completions/iw.fish Outdated Show resolved Hide resolved
share/completions/iw.fish Outdated Show resolved Hide resolved
@rianadon rianadon changed the title WIP Add initial set of iw completions Add iw completions Oct 23, 2019
@rianadon rianadon marked this pull request as ready for review October 23, 2019 05:41
share/completions/iw.fish Outdated Show resolved Hide resolved
share/completions/iw.fish Outdated Show resolved Hide resolved
share/completions/iw.fish Show resolved Hide resolved
@krobelus
Copy link
Member

Merged as 947e46b thanks for the work!

I made some small fixes:

@@ -27,7 +27,6 @@ function __fish_complete_iw
         set -e cmd[2] # Allow other completions to complete as normal
     end
     if not set -q cmd[2]
-        set -e cmd[2]
         return # Uses completions from $iw_commands
     else if not set -q cmd[3]
         switch $cmd[2]
@@ -258,9 +257,8 @@ function __fish_complete_iw
                     channels "Show available channels" \
                     reg "Manage regulatory domains" \
                     set "Set parameters" \
-                    get "Get parameters" \
+                    get "Get parameters"
             end
-        end
     end
 end

@krobelus krobelus closed this Oct 24, 2019
@zanchey zanchey added this to the fish 3.1.0 milestone Oct 24, 2019
@exploide exploide mentioned this pull request Oct 24, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants