Skip to content

completion: zpaq archiver #6245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 25, 2019
Merged

completion: zpaq archiver #6245

merged 5 commits into from
Oct 25, 2019

Conversation

239
Copy link
Contributor

@239 239 commented Oct 24, 2019

Description

Added completion for zpaq v7.15

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md


#shortcut
function _seen
__fish_seen_subcommand_from $argv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For such an abbreviation, you could use local variable for the same effect. The variable does not linger in the global scope, unlike a function.

set -l seen __fish_seen_subcommand_from
complete -c zpaq -f -n "not $seen $commands" -a "$commands"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful advice, thanks!

@krobelus krobelus added this to the fish 3.1.0 milestone Oct 25, 2019
@krobelus krobelus merged commit 6a9ab05 into fish-shell:master Oct 25, 2019
@krobelus
Copy link
Contributor

Merged, thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants