New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replace mode in vi-mode #6342

Closed

0x005c wants to merge 1 commit into fish-shell:master from 0x005c:vi-add-replace

+15 −0

Contributor

0x005c commented Nov 23, 2019

Description

Added replace mode.
Input 'R' in normal mode to enter replace mode.

In replace mode:

esc key to exit to normal mode
enter key to execute command and switch to insert mode
backspace key to move cursor backward ( This behaviour is different from vim. If previous character is changed by current replace mode, vim reverts the change, but implemented one does not revert. )
any other keys to replace character
prompt background is different from replace_one mode. background color of replace mode is cyan.

Fixes issue #1417

TODOs:

Changes to fish usage are reflected in user documentation/manpages.
Tests have been added for regressions fixed
User-visible changes noted in CHANGELOG.md


          Add replace mode in vi-mode

b859841

krobelus added the vi-mode label

ridiculousfish added a commit that referenced this pull request


          Relnote vi replace mode #6342

d11a508

zanchey added this to the fish 3.1.0 milestone

Member

zanchey commented Nov 26, 2019

This got merged as 48dc9b1 - thanks!

zanchey closed this

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.