New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Spelling Fixes #636

Closed
wants to merge 36 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@farmergreg
Copy link
Contributor

farmergreg commented Apr 1, 2013

Fixed spelling errors in much of the completion code.

farmergreg added some commits Apr 1, 2013

fix spelling of protocol in fish_complete_ssh.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in fish_complete_atool.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in fish_complete_list.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling of in fish_complete_tex.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in fish_complete_vi.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in fish_git_prompt.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in fish_gnu_complete.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in fish_make_completion.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in fish_not_contain_opt.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in trap.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in fish_complete_pgrep.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in fish_complete_pacman.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in apt-rdepends.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in apt-setup.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in chgrp.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in chown.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in compare.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in cut.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in df.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in du.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in effectv.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in fuser.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in git.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in grep.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in gunzip.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in gzip.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in hg.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in mount.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in scp.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in scrot.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>

farmergreg added some commits Apr 1, 2013

fix spelling in top.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in type.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
fix spelling in xterm.fish
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
@terlar

This comment has been minimized.

Copy link
Contributor

terlar commented Apr 1, 2013

Whoa, great work 👍

@ridiculousfish

This comment has been minimized.

Copy link
Member

ridiculousfish commented Apr 1, 2013

Holy cow!!!

Did you find these manually, or use an automated tool?

One minor nitpick FYI - "NUL character" is correct. "The null character" or "NUL", as distinguished from NULL, the null pointer. Yeah, it makes no sense.

@ridiculousfish

This comment has been minimized.

Copy link
Member

ridiculousfish commented Apr 1, 2013

Squash merged here:
To git@github.com:fish-shell/fish-shell.git
72b5988..b4447bf master -> master
Thanks again for this great cleanup and polish.

@siteshwar

This comment has been minimized.

Copy link
Member

siteshwar commented Apr 1, 2013

Hats off !

@farmergreg

This comment has been minimized.

Copy link
Contributor

farmergreg commented Apr 1, 2013

you're welcome :) I didn't expect such a great response!

I stumbled across fish while considering a switch from bash to zsh and really loved the idea of a modern shell that doesn't need a lot of configuration to get all of the "good" stuff. Anyway, grammar / spelling is boring, but important if we want folks to take fish seriously as an everyday shell :) I started by fixing one command that was bothering me, and then realized that there were a lot of fixes to be made... it only took a couple of hours to look through the rest of the auto complete code.

what tools.... I used vim with spell checking enabled and scrolled through each file to visually pick out what needed changing.

farmergreg added some commits Apr 1, 2013

Revert "fix spelling in git.fish"
"NUL" is the proper terminology

This reverts commit 77c9823.
Revert "fix spelling in hg.fish"
"NUL" is the proper terminology

This reverts commit 9083adc.
they're should be 'there are'
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>

@farmergreg farmergreg closed this Apr 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment