Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Spelling Fixes #636

Closed
wants to merge 36 commits into from
Closed

Various Spelling Fixes #636

wants to merge 36 commits into from

Conversation

@farmergreg
Copy link
Contributor

@farmergreg farmergreg commented Apr 1, 2013

Fixed spelling errors in much of the completion code.

farmergreg added 30 commits Apr 1, 2013
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
farmergreg added 3 commits Apr 1, 2013
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
@terlar
Copy link
Contributor

@terlar terlar commented Apr 1, 2013

Whoa, great work 👍

@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Apr 1, 2013

Holy cow!!!

Did you find these manually, or use an automated tool?

One minor nitpick FYI - "NUL character" is correct. "The null character" or "NUL", as distinguished from NULL, the null pointer. Yeah, it makes no sense.

@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Apr 1, 2013

Squash merged here:
To git@github.com:fish-shell/fish-shell.git
72b5988..b4447bf master -> master
Thanks again for this great cleanup and polish.

@siteshwar
Copy link
Member

@siteshwar siteshwar commented Apr 1, 2013

Hats off !

@farmergreg
Copy link
Contributor Author

@farmergreg farmergreg commented Apr 1, 2013

you're welcome :) I didn't expect such a great response!

I stumbled across fish while considering a switch from bash to zsh and really loved the idea of a modern shell that doesn't need a lot of configuration to get all of the "good" stuff. Anyway, grammar / spelling is boring, but important if we want folks to take fish seriously as an everyday shell :) I started by fixing one command that was bothering me, and then realized that there were a lot of fixes to be made... it only took a couple of hours to look through the rest of the auto complete code.

what tools.... I used vim with spell checking enabled and scrolled through each file to visually pick out what needed changing.

farmergreg added 3 commits Apr 1, 2013
"NUL" is the proper terminology

This reverts commit 77c9823.
"NUL" is the proper terminology

This reverts commit 9083adc.
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
@farmergreg farmergreg closed this Apr 1, 2013
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants