Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tmux auto completion #639

Closed
wants to merge 7 commits into from
Closed

Conversation

@farmergreg
Copy link
Contributor

@farmergreg farmergreg commented Apr 3, 2013

This pull request adds additional functionality to tmux completion. It also puts in place a structure that will organize and enable future implementation of tmux features that are not currently supported.

This request also addresses the -t use case that prompted #584.

@farmergreg
Copy link
Contributor Author

@farmergreg farmergreg commented Apr 3, 2013

let me know if anything can be improved upon. I'm happy to re-spin and work towards getting this bit of code perfect

For the time being, I am unlikely to work on implementing the remaining missing features. Therefore, I've tried to make clear what is working and what is missing.

@farmergreg
Copy link
Contributor Author

@farmergreg farmergreg commented Apr 3, 2013

also, as I worked on this patch set, the __fish_use_subcommand function's name is confusing to me. I didn't rename it, but perhaps calling it something like __fish_no_subcommand or __fish_not_seen_subcommand would be more appropriate?

farmergreg added 7 commits Apr 3, 2013
Fully implement all tmux commands found in the tmux man
page section titled: "CLIENTS AND SESSIONS"

Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
implement the commands in the KEY BINDINGS man page section

Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Apr 5, 2013

Squash merged as 46edc49 . Thanks for the nice contribution.

Two nitpicks:

1. seq on BSDs (and OS X) do the wrong thing when passed 0. The usual fix is to guard calls to seq with an if check. I added that.
2. tmux invocations inside command substitutions should have stderr piped to /dev/null too

Otherwise looks great! I implemented both of those.

@zanchey zanchey added this to the fish 2.1.0 milestone Jul 14, 2014
@zanchey zanchey added this to the fish 2.0 (first stable release) milestone Jul 14, 2014
@zanchey zanchey removed this from the fish 2.1.0 milestone Jul 14, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants