Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add completions for cryptsetup #6488

Merged
merged 2 commits into from Jan 13, 2020
Merged

Add completions for cryptsetup #6488

merged 2 commits into from Jan 13, 2020

Conversation

239
Copy link
Contributor

@239 239 commented Jan 10, 2020 •
edited

Description

Added completions for cryptsetup. I'm not sure whether it's useful since in most cases it is used before fish is even available.

Fixes issue #

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md

@krobelus krobelus merged commit 56f52bc into fish-shell:master Jan 13, 2020
@krobelus krobelus added this to the fish 3.1.0 milestone Jan 13, 2020
@krobelus
Copy link
Member

Merged, thanks!

@zanchey
Copy link
Member

zanchey commented Jan 14, 2020

I've definitely used cryptsetup from within fish to manage non-boot encrypted drives.

@239 239 deleted the completions-cryptsetup branch January 14, 2020 12:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
completions enhancement
Projects
None yet
Milestone
fish 3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@239 @krobelus @zanchey