__fish_prepend_sudo: Don't move the relative position of the cursor #6542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment the "prepend sudo" functionality always sets the cursor to the end of the line. This changes it to restore the relative position of the cursor.
|
Yes, that's definitely an improvement. thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment the "prepend sudo" (Alt-S) functionality always sets the cursor to the end of the line. This changes it to restore the relative position of the cursor.
The functionality was added in #6140 (0f802ea). The PR description says "This does not move the cursor", which suggests that the current behaviour is a mistake.
For example, let's say the user entered
ls /rootand then moved the cursor to, e.g.where | is the cursor position. Running the function currently turns it to
whereas after this change it is
TODOs: