Add additional vi bindings #6648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds dh, dl, c0, cf, ct, cF, cT, ch, cl, and y0 bindings.
|
thank you! |
|
Merged as e1a08e3 |
3 tasks
faho
pushed a commit
that referenced
this pull request
Mar 21, 2020
Many people have mentioned wanting support for changing / yanking / deleting between "" and '', meaning the commands `ci' ci" yi' yi" di' di"`, so this adds that support in a generic, and thus potentially confusing way. The concept is that we check for the character backwards and forwards before making the selection. Unfortunately, this will also work for *any* character that isn't `w` or `W`, so `cia` could change everything between two `a` characters. Looking through the [bind documentation](https://fishshell.com/docs/current/cmds/bind.html) and input handler at `src/input.cpp`, this is the best possible solution I could come up with until `forward-jump` and `backward-jump` can accept input in the call to `bind`, and not just from stdin, meaning we can write a binding as: ``` bind di\" backward-jump-till \" and repeat-jump-reverse ...` ``` If that were done, then other commands such as `di)` to go between `()` would be possible. There are also some added `y` bindings not part of #6648. Let me know if you need anything else.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
dh,dl,c0,cf,ct,cF,cT,ch,cl, andy0bindings.Description
I added a couple of missing vim bindings. This is kind of related to #4019 even though the issues does not mention the missing bindings explicitly.
The
dhandchbindings delete the first character of the line when used at the beginning of the line. This is different from vim, but I did not find a clean way to fix this and I consider this a minor difference.I also noticed that the
y0binding pastes if used at the beginning of the line. This is the same for the already existingy^binding so I guess it is not a problem?TODOs: