Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent prompt barfing errors when cwd has disappeared #6699

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

ammgws
Copy link
Contributor

@ammgws ammgws commented Mar 2, 2020

In terminal one: cwd is "a"
In terminal two: removed dir "a"

Tried to run a command in terminal one and:

[1]>ls                                                                                               0ms|20:58:04
pwd: realpath failed:test: Missing argument at index 2

/usr/share/fish/functions/fish_print_hg_root.fish (line 11): 
    while test $dir != "/"
          ^
in function 'fish_print_hg_root'
	called on line 1 of file /usr/share/fish/functions/fish_hg_prompt.fish
in command substitution
	called on line 30 of file /usr/share/fish/functions/fish_hg_prompt.fish
in function 'fish_hg_prompt'
	called on line 5 of file /usr/share/fish/functions/fish_vcs_prompt.fish
in function 'fish_vcs_prompt'
	called on line 1 of file ~/.config/fish/functions/fish_right_prompt.fish
in command substitution
	called on line 1 of file ~/.config/fish/functions/fish_right_prompt.fish
in command substitution
	called on line 8 of file ~/.config/fish/functions/fish_right_prompt.fish
in function 'fish_right_prompt'
in command substitution

(Type 'help test' for related documentation)

@ammgws ammgws changed the title Prevent prompt from spewing out errorsprompt spewing errors when cwd has disappeared Prevent prompt barfing errors when cwd has disappeared Mar 2, 2020
@faho faho added the bug Something that's not working as intended label Mar 3, 2020
@faho faho added this to the fish 3.1.1 milestone Mar 3, 2020
@faho faho merged commit 86b7c10 into fish-shell:master Mar 3, 2020
@faho
Copy link
Member

faho commented Mar 3, 2020

Thanks, merged to 3.1.1 as 33f55e0.

@ammgws ammgws deleted the fixpromptbarf branch March 3, 2020 21:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something that's not working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants