Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completions update #6788

Merged
merged 12 commits into from Apr 25, 2020
Merged

Completions update #6788

merged 12 commits into from Apr 25, 2020

Conversation

239
Copy link
Contributor

@239 239 commented Mar 21, 2020

Description

  • Added completions for fd and windscribe
  • Updated previously added completions

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md

faho
faho requested changes Mar 21, 2020
View reviewed changes
Copy link
Member

@faho faho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove the fd completions, submit them upstream instead

  • Remove style changes, use fish_indent instead.

share/completions/fd.fish Outdated Show resolved Hide resolved
share/completions/cryptsetup.fish Outdated Show resolved Hide resolved
share/completions/keybase.fish Outdated Show resolved Hide resolved
share/completions/zpaq.fish Outdated Show resolved Hide resolved
@faho faho added this to the fish 3.2.0 milestone Mar 22, 2020
@faho faho merged commit 47677df into fish-shell:master Apr 25, 2020
@faho
Copy link
Member

faho commented Apr 25, 2020

Merged, sorry for the delay!

@239 239 deleted the completions-update branch April 25, 2020 19:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faho faho faho requested changes

Assignees
No one assigned
Labels
completions enhancement
Projects
None yet
Milestone
fish 3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@239 @faho