Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow finishing build on OS X <10.13.6 #6791

Conversation

malthejorgensen
Copy link
Contributor

@malthejorgensen malthejorgensen commented Mar 22, 2020

Description

Building on OS X versions prior to 10.13.6 fails at the very end when running codesign.
The -options runtime-argument isn't available on these earlier versions of the OS.

Simply running codesign without that argument on OS X <10.13.6 seems to produce a runnable binary with no security warnings. I'm on OS X 10.12.6, and but have not tested on setups than other my own, so I could have a lax security setting allowing this to work.
In any case the situation for people OS X <10.13.6 should be better as the build will at least finish with the.

Fixes issue #6792

This code change is most easily understood when ignoring whitespace (git diff -w: https://github.com/fish-shell/fish-shell/pull/6791/files?w=1)

Apple docs: https://developer.apple.com/documentation/xcode/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087724

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
    I don't think we need to change the docs. This is more a incompatibility fix/bug than a new feature or change.
  • Tests have been added for regressions fixed
    Unless, a specific setup for building on an older OS X setup becomes part of CI (I don't think it should), we can't write a test for this.
  • User-visible changes noted in CHANGELOG.md

Building on OS X versions prior to 10.13.6 fails at the very end when
running `codesign`.
The `-options runtime`-argument isn't available on these earlier
versions of the OS.

Simply running codesign without that argument (on OS X <10.13.6) seems
to produce a runnable binary with no security warnings.
@zanchey zanchey removed their request for review March 27, 2020 14:27
@ridiculousfish
Copy link
Member

Thank you!

@ridiculousfish
Copy link
Member

8a068ed

@zanchey zanchey linked an issue Apr 1, 2020 that may be closed by this pull request
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2020
@zanchey zanchey added this to the fish 3.2.0 milestone Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails at codesign on OS X <10.13.6
3 participants