Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow not removing files from destination dir #6796

Conversation

JanczarKurek
Copy link
Contributor

@JanczarKurek JanczarKurek commented Mar 23, 2020

Signed-off-by: JanczarKnurek jacek@beit.tech

Have something to do with: #6775

Generating completions always removes all files from destination dir.
Now it can be omitted by passing flag "--save".

Signed-off-by: JanczarKnurek <jacek@beit.tech>
@JanczarKurek JanczarKurek changed the title Allow not to remove files from destination dir Allow not removing files from destination dir Mar 23, 2020
@faho
Copy link
Member

faho commented Mar 23, 2020

I feel like "keep" is a better term here.

@faho faho added this to the fish 3.2.0 milestone Mar 23, 2020
@faho
Copy link
Member

faho commented Apr 4, 2020

Merged as f212aba, renamed the flag to "--keep" with 6e95e1d.

Thanks!

@faho faho closed this Apr 4, 2020
@zanchey zanchey linked an issue Apr 11, 2020 that may be closed by this pull request
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow fish_update_completions to skip already generated files
2 participants