Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish_vcs_prompt: allow argv passthrough #7033

Merged
merged 1 commit into from May 24, 2020
Merged

Conversation

ammgws
Copy link
Contributor

@ammgws ammgws commented May 23, 2020

fish_git_prompt encloses its output in brackets, however this can be changed by supplying a format string to it, i.e. fish_git_prompt %s.

However when using fish_vcs_prompt there's no way to pass on the arg to fish_git_prompt, so you need to manually remove the brackets from the output string.

fish_hg_prompt doesn't have the same format string support as fish_git_prompt, but I suppose it could be added later if needed.

fish_git_prompt encloses its output in brackets, however this can be changed by supplying a format string to it, i.e. `fish_git_prompt %s`.
However when using `fish_vcs_prompt` there's no way to pass on the arg to fish_git_prompt, so you need to manually remove it.
fish_hg_prompt doesn't have the same format string support as fish_git_prompt, but I suppose it could be added later if needed.
@faho faho added this to the fish 3.2.0 milestone May 23, 2020
@faho faho merged commit 7b9119c into fish-shell:master May 24, 2020
@faho
Copy link
Member

faho commented May 24, 2020

Yeah, that's right.

Tho we should improve the format string idea and document it.

@ammgws ammgws deleted the patch-1 branch May 24, 2020 21:38
ammgws added a commit to ammgws/dotfiles that referenced this pull request May 25, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants