Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completions for yadm #7100

Merged
merged 3 commits into from Jun 30, 2020
Merged

Conversation

sudormrfbin
Copy link
Contributor

@sudormrfbin sudormrfbin commented Jun 9, 2020

Description

Add completions for yadm. It's wraps around git and all of git's features are usable.

TODOs:

  • User-visible changes noted in CHANGELOG.rst
  • Suppress git completions for clone subcommand as yadm has clone with different options
  • yadm gitconfig should inherit completions from git config
  • Respect --yadm-repo option

I'm not sure if suppressing inherited completions for specific options is possible or not, so could use a pointer.

share/completions/yadm.fish Outdated Show resolved Hide resolved
@sudormrfbin
Copy link
Contributor Author

The completions have been finished and now react to --yadm-repo option. It also correctly inherits (only) needed completions from git.

share/completions/yadm.fish Outdated Show resolved Hide resolved
Copy link
Member

@krobelus krobelus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

share/completions/yadm.fish Outdated Show resolved Hide resolved
# See `yadm gitconfig` for setting git config values
function __fish_yadm_config_keys
yadm introspect configs
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this function could now be inlined, whatever you prefer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll leave it as is, because __fish_yadm_config_keys seems more readable and intuitive to me than yadm introspect configs

@krobelus krobelus merged commit 3f210ac into fish-shell:master Jun 30, 2020
@krobelus krobelus added this to the fish 3.2.0 milestone Jun 30, 2020
@krobelus
Copy link
Member

Thanks and sorry for the delay!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants