Don't chomp foo=
when completing foo=br
#7398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
complete_param_expand
knows how to handle cases likefoo=br
so wedon't need to bother sending just the
br
part. Furthermore, sendingjust
br
is incorrect because we will end up replacing the entirety offoo=br
with the result of the completion. That is,foo=br
will bereplaced with
bar
instead of being completed tofoo=bar
.Fixes a bug where the following
will be completed to just
instead of
This doesn't happen when the command is being invoked with
env
likeenv foo=/vr<TAB>
. It also only occurs when the completion requires replacement. Sofoo=/va
will correctly be completed tofoo=/var/
.TODOs: