Add support for copy and paste in WSL #7455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faho
reviewed
Nov 6, 2020
| @@ -8,6 +8,8 @@ function fish_clipboard_paste | |||
| set data (xsel --clipboard 2>/dev/null) | |||
| else if type -q xclip | |||
| set data (xclip -selection clipboard -o 2>/dev/null) | |||
| else if type -q powershell.exe | |||
| set data (powershell.exe Get-Clipboard | tr -d '\r' 2>/dev/null) | |||
There was a problem hiding this comment.
That tr should be string trim -r -c \r (no need to silence stderr)
There was a problem hiding this comment.
Oh nice, thanks for pointing that out. Amended the commit
- clip.exe is used to copy to the Windows clipboard - There's no binary for pasting from the Windows clipboard so `Get-Clipboard` from powershell is used as a workaround. The superflous carriage return is stripped from the output.
|
Merged, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
The necessary commands for copying from and pasting to the Windows clipboard (through WSL) has been integrated to
fish_clipboard_copyandfish_clipboard_pasterespectively.Fixes issue #7454
TODOs: