Make fish_config theme match help #7523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, another screenshot after the changes, this time of the abbreviations tab:
I can't say I'm in love with the icons in this context. I'm thinking of replacing them with just a character, e.g. ✕ (U+2715) |
|
Threw in a bonus enhancement - f4f6eaa allows webconfig to work with truecolor. The prompt display would otherwise be monochrome. |
|
Alright, figured out how to get the tabs to just wrap the text, which is okay. Also removed some of the margins on screens with low width. Here's the prompt tab <700px wide:
|
Otherwise this would break colors if fish detected a truecolor terminal.
More consistency is nice.
For some reason this didn't like the min-height inside the ng-style thing.
This allows it to basically work down to quite small widths.
faho
force-pushed
the
fish_config-theme
branch
from
de8efdd to
2bbfb11
Compare
|
Alright, one final screenshot:
|
|
d9b7cdc adds the box shadows I missed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also fishshell.com, making it all consistent.
I'm not entirely sure if I've missed anything, and I'm not super happy with the overflow thing (without, it looks awful < ~500px width, with, the abbr tab eventually entirely falls off the screen).
But anyway, here's a screenshot:
Before:
After:
TODOs: