Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__fish_complete_suffix: complete all files, but sort files with matching suffix first #7547

merged 3 commits into from Dec 23, 2020


Copy link

@krobelus krobelus commented Dec 13, 2020


This is a compromise between the common case where the user only wants files with a matching suffix,
and the exceptional case when there is no file extension, or one file we don't know about.

See #7040 and others.


  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@faho faho added this to the fish 3.2.0 milestone Dec 14, 2020
Copy link

faho commented Dec 14, 2020

This looks like a great idea!

Copy link
Member Author

Many times when completing one of these commands, a single Tab already selects the only sensible option.
It's a bit sad to lose that.
Still, completing non-matching files seems like the least contentious solution.

@krobelus krobelus merged commit 4dae106 into fish-shell:master Dec 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants