Normalize and document __fish_status_to_signal #7597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! LGTM, if there are no other comments I will merge later today or tomorrow. |
faho
reviewed
Jan 1, 2021
|
Merged, thanks! |
tomoemon
added a commit
to tomoemon/fish-command-timer
that referenced
this pull request
Mar 15, 2021
From fish shell 3.2.0, __fish_status_to_signal function has been changed to fish_status_to_signal fish-shell/fish-shell#7597
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts
__fish_status_to_signaltofish_status_to_signalfor external use. Documentsfish_status_to_signaland adds it to the changelog.Fixes #7595
TODOs: