Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abbr: improve error handling when --erase called with no args #7732

Merged
merged 1 commit into from
Feb 20, 2021

Conversation

ammgws
Copy link
Contributor

@ammgws ammgws commented Feb 19, 2021

Before

> abbr --erase
set: Erase needs a variable name

/usr/share/fish/functions/abbr.fish (line 116): 
    set -e $abbr_var_names
    ^
in function '__fish_abbr_erase'
	called on line 42 of file /usr/share/fish/functions/abbr.fish
in function 'abbr' with arguments '--erase'

(Type 'help set' for related documentation)
[2]>

After

> abbr --erase
[1]>

@ammgws
Copy link
Contributor Author

ammgws commented Feb 19, 2021

# If run with no options, treat it like --add if we have arguments, or
# --show if we do not have any arguments.

Also this comment doesn't reflect the actual behaviour:
abbr --add (option with no arguments) ends up being treated as --show despite the option being supplied.

@ridiculousfish ridiculousfish merged commit 1f546ac into fish-shell:master Feb 20, 2021
@ridiculousfish
Copy link
Member

Thank you!

@ridiculousfish ridiculousfish added this to the fish 3.2.0 milestone Feb 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
@ammgws ammgws deleted the patch-4 branch October 16, 2021 07:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants