Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten read, user add, badblocks, curl completions #7788

Merged
merged 2 commits into from Mar 9, 2021

Conversation

Caroleq
Copy link
Contributor

@Caroleq Caroleq commented Mar 6, 2021

Description

PR shortens completions in:

  • read
  • useradd
  • badblocks
  • curl - from what I see fish uses completions from /usr/share/fish/vendor_completions.d, but it was included in the issue. Descriptions in curl.fish were copied from curl manual (https://curl.se/docs/manpage.html)

Fixes: #6981

Copy link
Member

@faho faho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks, I think the dangerous thing should be added, the rest are more of a question of taste.

share/completions/badblocks.fish Outdated Show resolved Hide resolved
complete -c read -s u -l unexport -d "Do not export variable to subprocess"
complete -c read -s m -l mode-name -d "Name to load/save history under" -r -a "read fish"
complete -c read -s c -l command -d "Initial contents of read buffer when reading interactively" -r
complete -c read -s S -l shell -d "Use syntax highlighting, tab completions and command termination suitable for entering shellscript code"
complete -c read -s s -l silent -d "Secure mode: mask characters at the command line (suitable for passwords)"
complete -c read -s S -l shell -d "Highlight syntax, complete tabs, terminate commands as in shellscript"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This listing feels a bit awkward.

Maybe something like "read like the shell would"?

share/completions/read.fish Outdated Show resolved Hide resolved
@faho faho added this to the fish 3.2.1 milestone Mar 8, 2021
@faho faho merged commit 9fe2b27 into fish-shell:master Mar 9, 2021
@faho
Copy link
Member

faho commented Mar 9, 2021

Merged, thanks!

@ammgws ammgws mentioned this pull request Mar 10, 2021
96 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
@floam floam changed the title Shorten description in completions Shorten read, user add, badblocks, curl completions Jan 17, 2022
@floam floam added this to In progress in Shorten Completion Descriptions via automation Jan 17, 2022
@floam floam moved this from In progress to Done in Shorten Completion Descriptions Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

completions: fix long descriptions
2 participants