Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed completion errors for tshark when running as root #7858

Merged
merged 1 commit into from Mar 23, 2021

Conversation

exploide
Copy link
Contributor

Description

When running as root, many tshark completions show the following error:

Running as user "root" and group "root". This could be dangerous.

This can be fixed by redirecting stderr.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@krobelus krobelus merged commit 0f3274d into fish-shell:master Mar 23, 2021
@krobelus krobelus added this to the fish 3.3.0 milestone Mar 23, 2021
@krobelus
Copy link
Member

Makes sense, thanks!

(Looks like the tmux tests are flaky, I'll try to increase the timeout..)

@exploide exploide deleted the tshark-root branch March 24, 2021 18:27
@zanchey zanchey modified the milestones: fish 3.3.0, fish 3.2.2 Apr 1, 2021
zanchey pushed a commit that referenced this pull request Apr 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants