Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added completions for firewall-cmd (firewalld) #7900

Closed
wants to merge 1 commit into from

Conversation

exploide
Copy link
Contributor

@exploide exploide commented Apr 4, 2021

Description

Added completions for firewall-cmd (firewalld).

Initially, I tried to submit the completions at the firewalld repository (firewalld/firewalld#588) but the processing of pull requests is a bit slow. So I thought it's equally fine to include them here.

Once this gets merged, I will close the PR at firewalld.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

based on --help and man page of firewall-cmd 0.9.x
@ridiculousfish
Copy link
Member

Merged as 89eeafe. Thank you!

@ridiculousfish ridiculousfish added this to the fish 3.3.0 milestone Apr 6, 2021
zanchey added a commit that referenced this pull request Apr 6, 2021
@exploide exploide deleted the firewall-cmd branch April 6, 2021 16:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants