Enhanced prepending commands to command line #7905
Conversation
|
I finally simplified the function as @faho asked me and there's no |
|
Can we have a similar function for appending? We already have |
|
This looks ready for 3.3.0? |
|
No, there are some issues remaining - spurious The two functions are not fully symmetrical. The "append" one ought to add to a whole job, but the "prepend" one is just for the current process. This also needs some changes. I started working on this but I'm not done yet. |
|
I ended up rewriting the functions a bit, let me know if I should add rationale. |
I almost always use this on the last/only job in a commandline, so the semicolon is usually not needed. We have always added it but I prefer not dropping it: this feels cleaner because it's what you'd type without the shortcut.
No behavior change intended. Will use the "buffer_part" computation in the next commit.
…ss/job With a command line like a | b <cursor> | c "commandline -C 0 --current-process" will place the cursor just left of "b".
This introduces two functions to - toggle a process prefix, used for adding "sudo" - add a job suffix, used for adding "&| less" Not sure if they are very useful; we'll see. Closes #7905
|
Merging just in time for 3.3.0, thanks! |
Description
There was a function called
__fish_prepend_sudowhich is very useful and I made some others for commands likegit,nvimand so. But it is a bit messy to define myself a whole lot of functions with just a word changing between them. I just created a "super-prepending" function :__fish_prepend. There's no more need for__fish_prepend_sudoso I deleted it and changed its occurences in the other files.This function is some lines longer than
__fish_prepend_sudobecause it needs to read arguments so it's obviously a little bit slower, but it doesn't affect the user experience and it has also a lot more features :-por--previousflags, you can add the last command in the history to the command line (Let__fish_prepend_sudouse the last commandline if there is no current one #7079)sudoacts smartly with prepending (prepends/removes after the wordsudoif the value is notsudo👍)-hand--helpAll it needs is at least one argument that isn't one of
-h,--help,-por--previousand it manages itself how to prepend or remove the value to/from the beginning of the lines. I put comments in the code so it's more readable, feel free to take a look!TODOs:
Changes to fish usage are reflected in user documentation/manpages.There's no place in the doc for this function. However, fish users should know__fish_prependreplaces__fish_prepend...