Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish_vi_key_bindings: bind s to follow vim visual behaviour #8039

Merged
merged 1 commit into from Jun 3, 2021
Merged

fish_vi_key_bindings: bind s to follow vim visual behaviour #8039

merged 1 commit into from Jun 3, 2021

Conversation

mtoohey31
Copy link
Contributor

Description

This change adds a binding that sets the s key's behaviour to match the c key's in visual mode. This mirrors vim's behaviour (see :h v_s in vim or neovim). It's probably not something anyone other than me uses since I've gotten into the bad habit of using s for changing in visual mode, but it is how vim works and s is current unbound in visual mode, so I figure it might as well be supported.

Fixes issue #

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

Not sure which of these ^ are applicable... let me know if there's anything else I need to do though!

This change adds a binding that sets the s key's behaviour to match
the c key's in visual mode. This mirrors vim's behaviour (see `:h v_s`
in vim or neovim).
@faho faho added this to the fish 3.3.0 milestone Jun 3, 2021
@faho faho merged commit 6ca9f9e into fish-shell:master Jun 3, 2021
@faho
Copy link
Member

faho commented Jun 3, 2021

Sure, why not.

Not sure which of these ^ are applicable... let me know if there's anything else I need to do though!

Honestly this doesn't really need testing, I'm adding the docs and changelog.

@mtoohey31
Copy link
Contributor Author

Awesome, thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants