Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion for azure cli (az) #8141

Merged
merged 2 commits into from
Jul 21, 2021

Conversation

kfkonrad
Copy link
Contributor

Description

This introduces completions for the Azure CLI az. az uses the argcomplete library for its completions and the code I've used is little more than a boilerplate snippet to access those completions.

argcomplete has been compatible with fish for over 2 years now (argcomplete!260), but this is (to my knowledge) the first time this is being added to fish-shell directly. The code is basically copied from a snippet mentioned in argcomplete!260, except I replaced myscript with az.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

share/completions/az.fish Outdated Show resolved Hide resolved
share/completions/az.fish Outdated Show resolved Hide resolved
share/completions/az.fish Outdated Show resolved Hide resolved
share/completions/az.fish Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
@faho faho merged commit 869c42d into fish-shell:master Jul 21, 2021
@faho
Copy link
Member

faho commented Jul 21, 2021

Merged, thanks!

@kfkonrad kfkonrad mentioned this pull request Jul 28, 2021
3 tasks
thunder-coding pushed a commit to thunder-coding/fish-shell that referenced this pull request Jul 28, 2021
* add completion for azure cli (az)

* alter az.fish to match faho's requests

Co-authored-by: Kevin Konrad <kevin.konrad@unicepta.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants