Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion for qmk #8180

Merged
merged 3 commits into from Jul 28, 2021
Merged

Conversation

kfkonrad
Copy link
Contributor

@kfkonrad kfkonrad commented Jul 28, 2021

Description

This PR adds completion for qmk. qmk is a CLI for managing, compiling and flashing firmware for custom keyboards. The code is based on the az completion since both programs use the same mechanism through argcomplete (see #8141 for reference)

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

Copy link
Member

@faho faho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please extract the function.

share/completions/qmk.fish Outdated Show resolved Hide resolved
@faho faho merged commit 413fd2f into fish-shell:master Jul 28, 2021
@faho
Copy link
Member

faho commented Jul 28, 2021

Thanks, merged!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants