Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completions for wslpath #8364

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Add completions for wslpath #8364

merged 2 commits into from
Oct 22, 2021

Conversation

KiruyaMomochi
Copy link
Contributor

Description

This PR adds completion for wslpath to fish.

wslpath is a command line tool to do WSL<->Windows path conversions.
Details can be found at WSL Release Notes, build 17046

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@faho faho merged commit be9b882 into fish-shell:master Oct 22, 2021
@faho
Copy link
Member

faho commented Oct 22, 2021

Merged, thanks!

@KiruyaMomochi
Copy link
Contributor Author

KiruyaMomochi commented Oct 22, 2021

Sorry but I seem have put wslpath's change log entry to a incorrect place.
It should be in fish 3.4.0 (released ???) ​instead of fish 2.7b1 (released October 31, 2017).

Should I create another Pull Request?
Again, I apologize for the inconvenience.

@faho
Copy link
Member

faho commented Oct 22, 2021

No worries, I'll just do it.

@faho
Copy link
Member

faho commented Oct 22, 2021

c747520

@KiruyaMomochi
Copy link
Contributor Author

Thanks!

@zanchey zanchey added this to the fish 3.4.0 milestone Dec 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants