Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wine command completions #8411

merged 8 commits into from
Nov 8, 2021

Wine command completions #8411

merged 8 commits into from
Nov 8, 2021


Copy link

@EmilyGraceSeville7cf EmilyGraceSeville7cf commented Nov 6, 2021


This PR is intended to create wine command completions.

Linked issue: #8412.


  • wine
  • wineboot
  • winemaker

Copy link

faho commented Nov 8, 2021

As a sidenote: There's typically no need to merge master back, and it can make it a bit hard to follow. If you need some changes in master, typically you'd rebase and force-push instead of merging.

But if you don't, merging doesn't really help since we can just rebase at merge time.

That being said: The changes themselves look good, thank you, merging now!

@faho faho merged commit 868a50b into fish-shell:master Nov 8, 2021
@faho faho added this to the fish 3.4.0 milestone Nov 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants