Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish_vi_cursor: add support for alternative foot terminfos #8422

Merged

Conversation

dnkl
Copy link
Contributor

@dnkl dnkl commented Nov 8, 2021

Foot has several terminfos:

  • foot - the default one
  • foot-direct - 24-bit color terminfo, similar to xterm-direct (used by e.g. emacs)
  • foot-extra - alternative to the ncurses provided terminfo, with a couple of extra, non-standard
    capabilities
  • foot-extra-direct - 24-bit color version of the above

There may also be other distro-custom terminfo names (serving the same purpose as foot-extra*)

Related to issue #8391

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

Foot has several terminfos:

* foot - the default one
* foot-direct - 24-bit color terminfo, similar to xterm-direct (used by e.g. emacs)
* foot-extra - alternative to the ncurses provided terminfo, with a couple of extra, non-standard
capabilities
* foot-extra-direct - 24-bit color version of the above

There may also be other distro-custom terminfo names (serving the same purpose as foot-extra*)
@faho
Copy link
Member

faho commented Nov 8, 2021

You probably want to touch

and test 0"$VTE_VERSION" -ge 3405 -o "$TERM_PROGRAM" = Apple_Terminal -a (string match -r '\d+' 0"$TERM_PROGRAM_VERSION") -ge 309 -o "$TERM_PROGRAM" = WezTerm -o "$TERM" = foot
as well. That's the only other spot we mention foot atm I can find.

@faho faho added this to the fish 3.4.0 milestone Nov 8, 2021
@dnkl
Copy link
Contributor Author

dnkl commented Nov 8, 2021

You probably want to touch

Done. However, I'm very unused to fish shell scripting... let me know if there's a better way to do this.

@dnkl dnkl force-pushed the fish-vi-cursor-alternative-foot-terminfos branch from 088d445 to 0f65843 Compare November 8, 2021 20:04
@faho faho merged commit 20a1bf2 into fish-shell:master Nov 8, 2021
@faho
Copy link
Member

faho commented Nov 8, 2021

Thank you very much, merged!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants